@dirrao This is to do string search and it has to process each line to apply color ansi codes. This is already done on whole log file to apply log level class based on info, error, warning etc and to build filters. I haven't benchmarked it but I don't see this adding much overhead.

@dirrao This is to do string search and it has to process each line to apply color ansi codes. This is already done on whole log file to apply log level class based on info, error, warning etc and to build filters. I haven't benchmarked it but I don't see this adding much overhead.

In case of data workloads the logs are too heavy on the client side. I believe test it once with bulky logs to see the obvious issues.

cc: @jscheffl

@dirrao @jscheffl Used below dag which generated around 30MB log file and the function call added around 15ms with total render time taking 9-10 seconds. I did it with dev builds using "yarn dev" since the function name was not searchable in production mode possibly due to no source mapping. Please let me know if I missed anything. Thanks

from datetime import datetime

from airflow import DAG
from airflow.decorators import task

with DAG(
    dag_id="perf_39006",
    start_date=datetime(2024, 1, 1),
    catchup=False,
    schedule_interval=None,
) as dag:

    @task
    def log_line_generator():
        import random

        lorem_ipsum_words = "Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor".split()

        for _ in range(200_000):
            random.shuffle(lorem_ipsum_words)
            line = " ".join(lorem_ipsum_words)
            rand = random.random()

            if rand > 0.9:
                print(f"{line} error")
            elif rand > 0.8:
                print(f"{line} warn")
            else:
                print(line)

    log_line_generator()

Without patch

With patch :

The legacy log view doesn't have code changes to process every line. It just has the whole log as a single string so doing splitting and then adding ansi codes to join them back was more work that I left off since there is an issue to remove legacy log view especially with full-screen mode and other improvements being made to new UI.